Add flashtestations integration tests #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
force-pushed
the
add-flashtestation-builder-tx
branch
from
46380ae to
41c42bf
Compare
avalonche
force-pushed
the
add-flashtestation-integration-tests
branch
2 times, most recently
from
c5355b4 to
a84c2bc
Compare
avalonche
force-pushed
the
add-flashtestation-builder-tx
branch
from
41c42bf to
01573b2
Compare
avalonche
force-pushed
the
add-flashtestation-integration-tests
branch
from
a84c2bc to
3757a28
Compare
SozinM
approved these changes
Oct 2, 2025
avalonche
force-pushed
the
add-flashtestation-builder-tx
branch
from
01573b2 to
32146ac
Compare
avalonche
force-pushed
the
add-flashtestation-integration-tests
branch
from
3757a28 to
525f5da
Compare
avalonche
force-pushed
the
add-flashtestation-builder-tx
branch
from
32146ac to
2499332
Compare
avalonche
force-pushed
the
add-flashtestation-integration-tests
branch
from
3997fe0 to
260cb95
Compare
avalonche
force-pushed
the
add-flashtestation-builder-tx
branch
from
11f6b6a to
5787983
Compare
avalonche
force-pushed
the
add-flashtestation-integration-tests
branch
from
260cb95 to
2bd3b66
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds full flashtestations integration support: contract deployment utilities, builder transaction logic (funding, registration, block proof), an in-test attestation server, and end-to-end integration tests. Also broadens the payload builder context API and introduces new test constants/signers.
- Introduces FlashtestationsBuilderTx with registration and block proof flows.
- Adds integration tests covering registration, block proofs, and interaction with flashblock number contract.
- Expands OpPayloadBuilderCtx method visibility and adds an in-process mock attestation HTTP server for tests.
Reviewed Changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 20 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/op-rbuilder/src/tests/mod.rs | Registers new flashtestations test module and adds test addresses. |
| crates/op-rbuilder/src/tests/framework/utils.rs | Adds deployment/init helpers, workload addition, signer selection adjustments, and fixes a typo in a method name. |
| crates/op-rbuilder/src/tests/framework/mod.rs | Adds new signer keys and flashtestations constants. |
| crates/op-rbuilder/src/tests/framework/instance.rs | Adds mock attestation server lifecycle and accessors. |
| crates/op-rbuilder/src/tests/framework/artifacts/genesis.json.tmpl | Funds additional test accounts. |
| crates/op-rbuilder/src/tests/flashtestations.rs | New integration tests for registration, block proofs, and number contract interaction. |
| crates/op-rbuilder/src/tests/flashblocks.rs | Switches to shared FLASHBLOCKS_NUMBER_ADDRESS constant and removes unused imports. |
| crates/op-rbuilder/src/flashtestations/service.rs | Refactors service to use new builder_tx module and passes builder policy address. |
| crates/op-rbuilder/src/flashtestations/mod.rs | Adds LogMismatch revert reason and exports builder_tx module. |
| crates/op-rbuilder/src/flashtestations/builder_tx.rs | Implements Flashtestations builder transaction logic (funding, registration, block proof). |
| crates/op-rbuilder/src/flashtestations/attestation.rs | Improves log message clarity for remote quote fetching. |
| crates/op-rbuilder/src/builders/standard/builder_tx.rs | Updates import path for FlashtestationsBuilderTx. |
| crates/op-rbuilder/src/builders/flashblocks/builder_tx.rs | Uses new BuilderTransactionError::other helper for clearer error construction. |
| crates/op-rbuilder/src/builders/context.rs | Makes previously module-private builder context accessors public. |
| crates/op-rbuilder/src/builders/builder_tx.rs | Adds helper constructor for Other variant of BuilderTransactionError. |
| crates/op-rbuilder/Cargo.toml | Adds HTTP server dependencies for testing profile. |
| README.md | Updates flashtestations run example flags. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+583
to
+589
| impl Drop for AttestationServer { | ||
| fn drop(&mut self) { | ||
| if let Some(tx) = self.shutdown_tx.take() { | ||
| let _ = tx.send(()); | ||
| } | ||
| tracing::info!("AttestationServer dropped, terminating server"); | ||
| } |
There was a problem hiding this comment.
Dropping only signals shutdown without awaiting the server task; the listener may still accept connections briefly, leading to potential race conditions or port reuse issues. Consider storing the JoinHandle and awaiting it in an async shutdown path or joining in a separate background task to ensure orderly termination.
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Add test utils for deploying flashtestation contracts (using the mock quote contract) and integration tests.
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test